Skip to content
Snippets Groups Projects

Draft: feat(security): put /storage behind an auth wall

Open Gwen Le Bihan requested to merge lebihae/storage-authwall into lebihae/private-profiles
1 unresolved thread
  • frappe documents
  • event's pictures
  • posts' pictures

probably requires moving all src/modules/*/utils/permissions.ts files to src/permissionts/*.ts, so that src/server/storage.ts has access to them.

they don't rely on graphql types or functions anyways (afaik) so it shouldn't be a big deal

and it'll make sure we don't have unclear function names like canEdit that would be confusing when used outside of its own api module anyway

Edited by Gwen Le Bihan

Merge request reports

Merge request pipeline #14418 failed

Merge request pipeline failed for 1aaa2930

Ready to merge by members who can write to the target branch.

Merge details

  • 0 commits and 1 merge commit will be added to .
  • Source branch will not be deleted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading